diff options
author | Joel Challis <[email protected]> | 2022-12-09 01:42:22 +0000 |
---|---|---|
committer | GitHub <[email protected]> | 2022-12-09 01:42:22 +0000 |
commit | 99cd0b13e109bb14f1e5af023c5fcb5e50a78e0a (patch) | |
tree | f6b3198bca1321fb9f4b8c0903d87869a8816630 /keyboards/duck/jetfire | |
parent | ba6ee2904066aa64fa83417dc865f24dc76d991b (diff) | |
download | qmk_firmware-99cd0b13e109bb14f1e5af023c5fcb5e50a78e0a.tar.gz qmk_firmware-99cd0b13e109bb14f1e5af023c5fcb5e50a78e0a.zip |
Refactor some led_set_kb instances (#19179)
* Refactor some led_set_kb instances
* Apply suggestions from code review
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Ryan <[email protected]>
Diffstat (limited to 'keyboards/duck/jetfire')
-rw-r--r-- | keyboards/duck/jetfire/jetfire.c | 39 |
1 files changed, 21 insertions, 18 deletions
diff --git a/keyboards/duck/jetfire/jetfire.c b/keyboards/duck/jetfire/jetfire.c index d648287156..7bebd7ad21 100644 --- a/keyboards/duck/jetfire/jetfire.c +++ b/keyboards/duck/jetfire/jetfire.c @@ -95,22 +95,25 @@ void backlight_update_state() show(); } -void led_set_kb(uint8_t usb_led) -{ - if(usb_led & (1<<USB_LED_CAPS_LOCK)) { - backlight_state_led |= 1<<STATE_LED_CAPS_LOCK; - } else { - backlight_state_led &= ~(1<<STATE_LED_CAPS_LOCK); - } - if(usb_led & (1<<USB_LED_SCROLL_LOCK)) { - backlight_state_led |= 1<<STATE_LED_SCROLL_LOCK; - } else { - backlight_state_led &= ~(1<<STATE_LED_SCROLL_LOCK); - } - if(usb_led & (1<<USB_LED_NUM_LOCK)) { - backlight_state_led |= 1<<STATE_LED_NUM_LOCK; - } else { - backlight_state_led &= ~(1<<STATE_LED_NUM_LOCK); - } - backlight_update_state(); +bool led_update_kb(led_t led_state) { + bool res = led_update_user(led_state); + if(res) { + if(led_state.caps_lock) { + backlight_state_led |= 1<<STATE_LED_CAPS_LOCK; + } else { + backlight_state_led &= ~(1<<STATE_LED_CAPS_LOCK); + } + if(led_state.scroll_lock) { + backlight_state_led |= 1<<STATE_LED_SCROLL_LOCK; + } else { + backlight_state_led &= ~(1<<STATE_LED_SCROLL_LOCK); + } + if(led_state.num_lock) { + backlight_state_led |= 1<<STATE_LED_NUM_LOCK; + } else { + backlight_state_led &= ~(1<<STATE_LED_NUM_LOCK); + } + backlight_update_state(); + } + return res; } |