diff options
| author | Tobias Schulte <[email protected]> | 2019-02-24 04:32:48 +0100 | 
|---|---|---|
| committer | Drashna Jaelre <[email protected]> | 2019-02-23 19:32:48 -0800 | 
| commit | a69e4406d4ab0a43077bc130dabda536b4fda9ab (patch) | |
| tree | 5912fc68e4a862ec3200300cc2302787b83f87d8 /quantum/process_keycode | |
| parent | 0f62383be57d2e3dacc79a76973295c73e805038 (diff) | |
| download | qmk_firmware-a69e4406d4ab0a43077bc130dabda536b4fda9ab.tar.gz qmk_firmware-a69e4406d4ab0a43077bc130dabda536b4fda9ab.zip | |
Fix Tx Bolt ghosting second character on key press (#5229)0.6.302
* convert tabs to spaces
* fix #4578: don't call gemini protocol code when in bolt mode
Add missing break; statements in switch. The missing break resulted in
a fall through and an additional processing of the gemini code.
Diffstat (limited to 'quantum/process_keycode')
| -rw-r--r-- | quantum/process_keycode/process_steno.c | 46 | 
1 files changed, 24 insertions, 22 deletions
| diff --git a/quantum/process_keycode/process_steno.c b/quantum/process_keycode/process_steno.c index 3051fade91..50a1ef2fcf 100644 --- a/quantum/process_keycode/process_steno.c +++ b/quantum/process_keycode/process_steno.c @@ -114,13 +114,13 @@ static void send_steno_chord(void) {    if (send_steno_chord_user(mode, chord)) {      switch(mode) {        case STENO_MODE_BOLT: -	send_steno_state(BOLT_STATE_SIZE, false); -	virtser_send(0); // terminating byte -	break; +        send_steno_state(BOLT_STATE_SIZE, false); +        virtser_send(0); // terminating byte +        break;        case STENO_MODE_GEMINI: -	chord[0] |= 0x80; // Indicate start of packet -	send_steno_state(GEMINI_STATE_SIZE, true); -	break; +        chord[0] |= 0x80; // Indicate start of packet +        send_steno_state(GEMINI_STATE_SIZE, true); +        break;      }    }    steno_clear_state(); @@ -161,7 +161,7 @@ bool process_steno(uint16_t keycode, keyrecord_t *record) {    switch (keycode) {      case QK_STENO_BOLT:        if (!process_steno_user(keycode, record)) { -	return false; +        return false;        }        if (IS_PRESSED(record->event)) {          steno_set_mode(STENO_MODE_BOLT); @@ -170,7 +170,7 @@ bool process_steno(uint16_t keycode, keyrecord_t *record) {      case QK_STENO_GEMINI:        if (!process_steno_user(keycode, record)) { -	return false; +        return false;        }        if (IS_PRESSED(record->event)) {          steno_set_mode(STENO_MODE_GEMINI); @@ -179,25 +179,27 @@ bool process_steno(uint16_t keycode, keyrecord_t *record) {      case STN__MIN...STN__MAX:        if (!process_steno_user(keycode, record)) { -	return false; +        return false;        }        switch(mode) { -	case STENO_MODE_BOLT: -	  update_state_bolt(keycode - QK_STENO, IS_PRESSED(record->event)); -	case STENO_MODE_GEMINI: -	  update_state_gemini(keycode - QK_STENO, IS_PRESSED(record->event)); +        case STENO_MODE_BOLT: +          update_state_bolt(keycode - QK_STENO, IS_PRESSED(record->event)); +          break; +        case STENO_MODE_GEMINI: +          update_state_gemini(keycode - QK_STENO, IS_PRESSED(record->event)); +          break;        }        // allow postprocessing hooks        if (postprocess_steno_user(keycode, record, mode, chord, pressed)) { -	if (IS_PRESSED(record->event)) { -	  ++pressed; -	} else { -	  --pressed; -	  if (pressed <= 0) { -	    pressed = 0; -	    send_steno_chord(); -	  } -	} +        if (IS_PRESSED(record->event)) { +          ++pressed; +        } else { +          --pressed; +          if (pressed <= 0) { +            pressed = 0; +            send_steno_chord(); +          } +        }        }        return false;    } | 
